Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5414)

Unified Diff: chrome/browser/interests/android/interests_service.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enable RVO by making types match Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/interests/android/interests_service.cc
diff --git a/chrome/browser/interests/android/interests_service.cc b/chrome/browser/interests/android/interests_service.cc
index 7da1aca219075ba603618cd70557dd47f8f27769..ad65e295656ad876a1e0000cfc9635b20babb812 100644
--- a/chrome/browser/interests/android/interests_service.cc
+++ b/chrome/browser/interests/android/interests_service.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/interests/android/interests_service.h"
#include <stddef.h>
+#include <utility>
#include "base/android/jni_android.h"
#include "base/android/jni_array.h"
@@ -68,10 +69,8 @@ void InterestsService::GetInterests(
InterestsFetcher* fetcher_raw_ptr = fetcher.get();
InterestsFetcher::InterestsCallback callback = base::Bind(
- &InterestsService::OnObtainedInterests,
- weak_ptr_factory_.GetWeakPtr(),
- base::Passed(fetcher.Pass()),
- j_callback);
+ &InterestsService::OnObtainedInterests, weak_ptr_factory_.GetWeakPtr(),
+ base::Passed(std::move(fetcher)), j_callback);
fetcher_raw_ptr->FetchInterests(callback);
}
@@ -87,7 +86,7 @@ void InterestsService::OnObtainedInterests(
scoped_ptr<std::vector<InterestsFetcher::Interest>> interests) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobjectArray> j_interests =
- ConvertInterestsToJava(env, interests.Pass());
+ ConvertInterestsToJava(env, std::move(interests));
Java_GetInterestsCallback_onInterestsAvailable(env,
j_callback.obj(),
j_interests.obj());

Powered by Google App Engine
This is Rietveld 408576698