[Mac] Prep for animating the Browser Action Buttons in and out....

[Mac] Prep for animating the Browser Action Buttons in and out.
Also fixes bug where the go button would overlap with the page/wrench menus upon uninstalling the last extension.

BUG=40003, 39200
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43282

[rohitrao (ping after 24h), 2010-03-31 22:28:21]

LGTM

Is the mac trybot failure related?

http://codereview.chromium.org/1551009/diff/3001/4003
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/1551009/diff/3001/4003#newcode463
chrome/browser/cocoa/extensions/browser_actions_controller.mm:463: if
(!profile_->IsOffTheRecord() && isInitialized_)
Why does off-the-recordness matter?

[Bons, 2010-03-31 22:30:56]

http://codereview.chromium.org/1551009/diff/3001/4003
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/1551009/diff/3001/4003#newcode463
chrome/browser/cocoa/extensions/browser_actions_controller.mm:463: if
(!profile_->IsOffTheRecord() && isInitialized_)
On 2010/03/31 22:28:22, rohitrao wrote:
> Why does off-the-recordness matter?
An extension can be turned on for OTR, but we don't want to set this var in that
case (where there may be a small subset shown) until it has its own preference.

[Miranda Callahan, 2010-03-31 22:41:05]

LGTM indeed.