chrome/browser/cocoa/toolbar_controller.mm - Issue 1551009: [Mac] Prep for animating the Browser Action Buttons in and out....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/toolbar_controller.mm

Issue 1551009: [Mac] Prep for animating the Browser Action Buttons in and out.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/toolbar_controller.mm

===================================================================

--- chrome/browser/cocoa/toolbar_controller.mm (revision 43254)

+++ chrome/browser/cocoa/toolbar_controller.mm (working copy)

@@ -671,7 +671,8 @@

}

- (void)browserActionsVisibilityChanged:(NSNotification*)notification {

- [self pinGoButtonToLeftOfBrowserActionsContainerAndAnimate:NO];

+ [self pinGoButtonToLeftOfBrowserActionsContainerAndAnimate:

+ [[[self view] window] isVisible]];

}

- (void)pinGoButtonToLeftOfBrowserActionsContainerAndAnimate:(BOOL)animate {

@@ -679,7 +680,9 @@

CGFloat leftPadding;

if ([browserActionsContainerView_ isHidden]) {

- leftPadding = NSWidth([[goButton_ window] frame]) - goXPos;

+ CGFloat edgeXPos = [pageButton_ isHidden] ?

+ NSWidth([[goButton_ window] frame]) : [pageButton_ frame].origin.x;

+ leftPadding = edgeXPos - goXPos;

} else {

NSRect containerFrame = animate ?

[browserActionsContainerView_ animationEndFrame] :

« no previous file with comments | « chrome/browser/cocoa/extensions/browser_actions_controller.mm ('k') | no next file » | no next file with comments »