Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550933002: Let breakpad build with -Wall on OS X and Linux. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Let breakpad build with -Wall on OS X and Linux. BUG=

Patch Set 1 #

Patch Set 2 : linux1 #

Patch Set 3 : linux2 #

Patch Set 4 : linux3 #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M src/client/mac/handler/dynamic_images.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/common/dwarf/dwarf2reader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/common/dwarf/dwarf2reader.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/common/linux/libcurl_wrapper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/common/linux/synth_elf.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/common/linux/synth_elf.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M src/processor/minidump.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/tools/mac/symupload/symupload.m View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
I'd send this to Mark, but he's out this week.
4 years, 11 months ago (2015-12-29 14:56:21 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2015-12-29 19:29:50 UTC) #3
Nico
can you land patch set 5 for me? (and maybe have another look, you might've ...
4 years, 11 months ago (2015-12-29 19:38:28 UTC) #4
Lei Zhang
4 years, 11 months ago (2015-12-29 20:14:47 UTC) #6 
On 2015/12/29 19:38:28, Nico wrote:
> can you land patch set 5 for me? (and maybe have another look, you might've
> reviewed an earlier version. it's not very different though)

Done, CL for landing: https://codereview.chromium.org/1554613002

Powered by Google App Engine
This is Rietveld 408576698