Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 1554613002: Let breakpad build with -Wall on OS X and Linux. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M src/client/mac/handler/dynamic_images.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/common/dwarf/dwarf2reader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/common/dwarf/dwarf2reader.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/common/linux/libcurl_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/common/linux/synth_elf.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/common/linux/synth_elf.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/processor/minidump.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/tools/mac/symupload/symupload.m View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 11 months ago (2015-12-29 20:14:36 UTC) #2
Nico
rs-lgtm :-P
4 years, 11 months ago (2015-12-29 21:03:15 UTC) #3
Lei Zhang
4 years, 11 months ago (2015-12-29 21:42:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7ffb8c364cc31aa3263c003c339a68af8abf309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698