net/http/http_stream_factory_impl_request.h - Issue 1550843002: Convert enable_bidirectional_stream into build flag local to net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_request.h

Issue 1550843002: Convert enable_bidirectional_stream into build flag local to net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix net_unittests, restore BUILDFLAG checks in headers. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_request.h

diff --git a/net/http/http_stream_factory_impl_request.h b/net/http/http_stream_factory_impl_request.h

index d8d5476715c7b80e48e548c21998c5b18de3ca3e..a92303c97b912462ca26b1b4b7d06e892fa8a814 100644

--- a/net/http/http_stream_factory_impl_request.h

+++ b/net/http/http_stream_factory_impl_request.h

@@ -11,6 +11,7 @@

#include "base/memory/scoped_ptr.h"

#include "net/http/http_stream_factory_impl.h"

#include "net/log/net_log.h"

+#include "net/net_features.h"

#include "net/socket/connection_attempts.h"

#include "net/socket/ssl_client_socket.h"

#include "net/spdy/spdy_session_key.h"

@@ -73,7 +74,7 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {

void OnNewSpdySessionReady(

Job* job,

scoped_ptr<HttpStream> stream,

-#if defined(ENABLE_BIDIRECTIONAL_STREAM)

+#if BUILDFLAG(ENABLE_BIDIRECTIONAL_STREAM)

scoped_ptr<BidirectionalStreamJob> bidirectional_stream_spdy_job,

#else

void* unused,

« net/http/bidirectional_stream.h ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | net/net.gyp » ('J')