net/http/bidirectional_stream.h - Issue 1550843002: Convert enable_bidirectional_stream into build flag local to net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/bidirectional_stream.h

Issue 1550843002: Convert enable_bidirectional_stream into build flag local to net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix net_unittests, restore BUILDFLAG checks in headers. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/bidirectional_stream.h

diff --git a/net/http/bidirectional_stream.h b/net/http/bidirectional_stream.h

index 14063fb0e47758ff6441e161caeb5855dd86a6d0..5de3135e99dea9160a7cd48d6a0bbb4c1c89fda2 100644

--- a/net/http/bidirectional_stream.h

+++ b/net/http/bidirectional_stream.h

@@ -13,8 +13,9 @@

#include "net/http/bidirectional_stream_job.h"

#include "net/http/http_stream_factory.h"

#include "net/log/net_log.h"

+#include "net/net_features.h"

-#if !defined(ENABLE_BIDIRECTIONAL_STREAM)

+#if !BUILDFLAG(ENABLE_BIDIRECTIONAL_STREAM)

mmenke 2016/01/07 18:16:41 Should all these files include "build/buildflag.h"

mef 2016/01/07 19:41:31 It is included into "net/net_features.h"

#error Only include this if ENABLE_BIDIRECTIONAL_STREAM is defined

#endif

« no previous file with comments | « net/BUILD.gn ('k') | net/http/bidirectional_stream_job.h » ('j') | net/net.gyp » ('J')