mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 1550733002: Convert Pass()→std::move() in generated Mojo bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 1550733002: Convert Pass()→std::move() in generated Mojo bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index ff9bb12ec8bbe1d062160a709e046a0db3478e2c..47068c533077dc691ed8737a04f562ead0bd5b59 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -87,7 +87,7 @@

{%- endif %}

{%- elif kind|is_any_handle_kind or kind|is_interface_kind %}

{%- if kind|is_interface_kind %}

- mojo::internal::InterfacePointerToData({{input_field}}.Pass(), &{{output}}->{{name}});

+ mojo::internal::InterfacePointerToData(std::move({{input_field}}), &{{output}}->{{name}});

{%- elif kind|is_interface_request_kind %}

{{output}}->{{name}} = {{input_field}}.PassMessagePipe().release();

{%- else %}

@@ -106,7 +106,7 @@

{%- elif kind|is_associated_kind %}

// TODO(yzshen): add some DCHECKs for non-nullable, is_local, correct router, etc.

{%- if kind|is_associated_interface_kind %}

- mojo::internal::AssociatedInterfacePtrInfoToData({{input_field}}.Pass(), &{{output}}->{{name}});

+ mojo::internal::AssociatedInterfacePtrInfoToData(std::move({{input_field}}), &{{output}}->{{name}});

{%- else %}

{{output}}->{{name}} = mojo::internal::AssociatedInterfaceRequestHelper::PassHandle(&{{input_field}}).release();

{%- endif %}