Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1550693002: Global conversion of Pass()→std::move() on Linux (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, danakj, darin (slow to review), darin-cc_chromium.org, extensions-reviews_chromium.org, jam, kalyank, piman+watch_chromium.org, qsr+mojo_chromium.org, sadrul, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Global conversion of Pass()→std::move() on OS==linux ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/e486004502c17ab80953ef324926a536b8030d1e Cr-Commit-Position: refs/heads/master@{#366956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -195 lines) Patch
M apps/custom_launcher_page_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/saved_files_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/service/service_state.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M crypto/nss_key_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/exported_object.cc View 2 chunks +2 lines, -1 line 0 comments Download
M dbus/message.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M dbus/object_proxy.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M dbus/test_service.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M gin/isolate_holder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M gin/modules/module_registry.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M gin/per_isolate_data.cc View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ipc/ipc_test_base.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 12 chunks +27 lines, -21 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_message_pipe_reader.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_handle_attachment.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_message_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M jingle/glue/chrome_async_socket.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M jingle/glue/fake_ssl_client_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/fake_ssl_client_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/xmpp_client_socket_factory.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mash/example/window_type_launcher/main.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mash/wm/accelerator_registrar_impl.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M mash/wm/window_manager_application.cc View 6 chunks +12 lines, -8 lines 0 comments Download
M mash/wm/window_manager_apptest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mash/wm/window_manager_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/printed_document.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M printing/printed_page.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/host/video_frame_recorder_host_extension.cc View 2 chunks +3 lines, -1 line 0 comments Download
M sql/connection.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M sql/mojo/mojo_vfs.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M sql/mojo/sql_test_base.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M sql/mojo/vfs_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sql/recovery.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/recovery_unittest.cc View 16 chunks +17 lines, -16 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_storage_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/json.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.cc View 3 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
dcheng
This should be the remainder of the instances when building on Linux. After this, I'm ...
4 years, 12 months ago (2015-12-28 00:30:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550693002/1
4 years, 12 months ago (2015-12-28 00:32:20 UTC) #4
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-28 00:44:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 02:06:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550693002/1
4 years, 12 months ago (2015-12-28 02:19:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 02:24:59 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e486004502c17ab80953ef324926a536b8030d1e Cr-Commit-Position: refs/heads/master@{#366956}
4 years, 12 months ago (2015-12-28 02:26:10 UTC) #12
Nico
For the third-party stuff, shouldn't this update any readme files?
4 years, 12 months ago (2015-12-28 23:40:09 UTC) #14
dcheng
On 2015/12/28 at 23:40:09, thakis wrote: > For the third-party stuff, shouldn't this update any ...
4 years, 12 months ago (2015-12-28 23:42:19 UTC) #15
ericmarkswank86
4 years, 11 months ago (2016-01-28 00:43:51 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698