Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: third_party/zlib/google/zip_reader.cc

Issue 1550693002: Global conversion of Pass()→std::move() on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libaddressinput/chromium/json.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/google/zip_reader.cc
diff --git a/third_party/zlib/google/zip_reader.cc b/third_party/zlib/google/zip_reader.cc
index 441a09835286c7813c0e93998a78390bba39a4ee..91d2ec329dea2fbe01a60e8d1d370dc0be5e836a 100644
--- a/third_party/zlib/google/zip_reader.cc
+++ b/third_party/zlib/google/zip_reader.cc
@@ -4,6 +4,8 @@
#include "third_party/zlib/google/zip_reader.h"
+#include <utility>
+
#include "base/bind.h"
#include "base/files/file.h"
#include "base/logging.h"
@@ -394,13 +396,9 @@ void ZipReader::ExtractCurrentEntryToFilePathAsync(
base::MessageLoop::current()->PostTask(
FROM_HERE,
- base::Bind(&ZipReader::ExtractChunk,
- weak_ptr_factory_.GetWeakPtr(),
- Passed(output_file.Pass()),
- success_callback,
- failure_callback,
- progress_callback,
- 0 /* initial offset */));
+ base::Bind(&ZipReader::ExtractChunk, weak_ptr_factory_.GetWeakPtr(),
+ Passed(std::move(output_file)), success_callback,
+ failure_callback, progress_callback, 0 /* initial offset */));
}
bool ZipReader::ExtractCurrentEntryIntoDirectory(
@@ -505,14 +503,9 @@ void ZipReader::ExtractChunk(base::File output_file,
base::MessageLoop::current()->PostTask(
FROM_HERE,
- base::Bind(&ZipReader::ExtractChunk,
- weak_ptr_factory_.GetWeakPtr(),
- Passed(output_file.Pass()),
- success_callback,
- failure_callback,
- progress_callback,
- current_progress));
-
+ base::Bind(&ZipReader::ExtractChunk, weak_ptr_factory_.GetWeakPtr(),
+ Passed(std::move(output_file)), success_callback,
+ failure_callback, progress_callback, current_progress));
}
}
« no previous file with comments | « third_party/libaddressinput/chromium/json.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698