Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1550503002: Switch to standard integer types in base/threading/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/threading/. BUG=138542 TBR=mark@chromium.org Committed: https://crrev.com/9ceb8b82f9e1abaefd886aeaf189544dbb50d2fd Cr-Commit-Position: refs/heads/master@{#366837}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -46 lines) Patch
M base/threading/non_thread_safe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/platform_thread.h View 1 chunk +3 lines, -1 line 0 comments Download
M base/threading/platform_thread_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/platform_thread_freebsd.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/platform_thread_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/platform_thread_mac.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M base/threading/platform_thread_posix.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M base/threading/platform_thread_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/sequenced_task_runner_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 1 chunk +3 lines, -1 line 0 comments Download
M base/threading/sequenced_worker_pool.cc View 8 chunks +11 lines, -8 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/threading/simple_thread.h View 1 chunk +4 lines, -3 lines 0 comments Download
M base/threading/thread.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/threading/thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/thread_checker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/thread_collision_warner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_collision_warner_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/thread_id_name_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_local.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/threading/thread_local_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/thread_local_storage.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/threading/thread_local_storage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/thread_local_storage_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/thread_perftest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/thread_restrictions.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M base/threading/watchdog.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/watchdog_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/worker_pool.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/threading/worker_pool_posix_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/worker_pool_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/offline_page_metadata_store.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/offline_page_metadata_store_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/offline_page_metadata_store_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/test_media_transfer_protocol_manager_linux.h View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M components/storage_monitor/test_media_transfer_protocol_manager_linux.cc View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/dom_storage/dom_storage_dispatcher.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/main_thread_input_event_filter.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550503002/1
5 years ago (2015-12-24 03:58:01 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/152830)
5 years ago (2015-12-24 04:11:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550503002/20001
5 years ago (2015-12-24 06:24:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/73831)
5 years ago (2015-12-24 06:40:29 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550503002/40001
5 years ago (2015-12-24 07:10:49 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550503002/60001
5 years ago (2015-12-24 07:16:21 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/2581)
4 years, 12 months ago (2015-12-24 07:46:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550503002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550503002/80001
4 years, 12 months ago (2015-12-24 16:42:54 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/2613)
4 years, 12 months ago (2015-12-24 17:10:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550503002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550503002/100001
4 years, 12 months ago (2015-12-24 20:30:46 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 12 months ago (2015-12-24 21:54:10 UTC) #21
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 21:55:16 UTC) #23
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/9ceb8b82f9e1abaefd886aeaf189544dbb50d2fd
Cr-Commit-Position: refs/heads/master@{#366837}

Powered by Google App Engine
This is Rietveld 408576698