components/offline_pages/offline_page_metadata_store_impl.cc - Issue 1550503002: Switch to standard integer types in base/threading/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_metadata_store_impl.cc

Issue 1550503002: Switch to standard integer types in base/threading/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/offline_page_metadata_store_impl.h ('k') | components/storage_monitor/test_media_transfer_protocol_manager_linux.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_metadata_store_impl.cc

diff --git a/components/offline_pages/offline_page_metadata_store_impl.cc b/components/offline_pages/offline_page_metadata_store_impl.cc

index ee2fb85bd37c5f0a4ef082caa3bba3d2c4376132..1b98fb18eaf7744e29a62c4838de3f8e96c3b0b3 100644

--- a/components/offline_pages/offline_page_metadata_store_impl.cc

+++ b/components/offline_pages/offline_page_metadata_store_impl.cc

@@ -192,14 +192,14 @@ void OfflinePageMetadataStoreImpl::AddOrUpdateOfflinePage(

}

void OfflinePageMetadataStoreImpl::RemoveOfflinePages(

- const std::vector<int64>& bookmark_ids,

+ const std::vector<int64_t>& bookmark_ids,

const UpdateCallback& callback) {

scoped_ptr<ProtoDatabase<OfflinePageEntry>::KeyEntryVector> entries_to_save(

new ProtoDatabase<OfflinePageEntry>::KeyEntryVector());

scoped_ptr<std::vector<std::string>> keys_to_remove(

new std::vector<std::string>());

- for (int64 id : bookmark_ids)

+ for (int64_t id : bookmark_ids)

keys_to_remove->push_back(base::Int64ToString(id));

UpdateEntries(entries_to_save.Pass(), keys_to_remove.Pass(), callback);