Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1550453002: Revert of Gold: Patch linker to implement --long-plt flag. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
Lei Zhang, pcc1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Gold: Patch linker to implement --long-plt flag. (patchset #1 id:1 of https://codereview.chromium.org/1537083003/ ) Reason for revert: Looks like this blocks pushing new clangs to goma (maybe the new binutils weren't uploaded there?), and also didn't help with the bug it was supposed to help with. Reverting in the hope that it'll unblock clang rolls. Original issue's description: > Gold: Patch linker to implement --long-plt flag. > > Also modify script to extract binutils sources from tarball and apply > patches unconditionally to avoid problems with later runs if a patch > fails to apply. > > BUG=554017 > R=thestig@chromium.org > > Committed: https://crrev.com/b7b010e70c37389b4e0ee022e5fd09a7d6bb394d > Cr-Commit-Position: refs/heads/master@{#366267} TBR=thestig@chromium.org,pcc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554017 Committed: https://crrev.com/1184a1d4472befc6a6076f5e2fac835b404a83d5 Cr-Commit-Position: refs/heads/master@{#366770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -262 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/binutils/build-all.sh View 1 chunk +18 lines, -22 lines 0 comments Download
D third_party/binutils/long-plt.patch View 1 chunk +0 lines, -232 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of Gold: Patch linker to implement --long-plt flag.
5 years ago (2015-12-23 20:54:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550453002/1
5 years ago (2015-12-23 20:54:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 20:55:24 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-23 20:56:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1184a1d4472befc6a6076f5e2fac835b404a83d5
Cr-Commit-Position: refs/heads/master@{#366770}

Powered by Google App Engine
This is Rietveld 408576698