Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 154983002: Convert android KEYCODE_MOVE_HOME/END correctly (Closed)

Created:
6 years, 10 months ago by hush (inactive)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Convert android KEYCODE_MOVE_HOME/END correctly to VKEY_HOME, VKEY_END BUG=340846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248920

Patch Set 1 #

Patch Set 2 : Fixing up the build bot breakage. Added the keycodes to keyboard_code_conversion_android.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/events/keycodes/keyboard_code_conversion_android.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hush (inactive)
Hi! Please take a look
6 years, 10 months ago (2014-02-04 23:12:27 UTC) #1
garykac
lgtm
6 years, 10 months ago (2014-02-04 23:19:15 UTC) #2
hush (inactive)
2 trybots failed and I see those trybots are using an old version of <android/keycodes.h> ...
6 years, 10 months ago (2014-02-05 00:56:56 UTC) #3
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 10 months ago (2014-02-05 04:24:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/154983002/60001
6 years, 10 months ago (2014-02-05 04:26:12 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:26:44 UTC) #6
Message was sent while issue was closed. 
Change committed as 248920

Powered by Google App Engine
This is Rietveld 408576698