Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/events/keycodes/keyboard_code_conversion_android.cc

Issue 154983002: Convert android KEYCODE_MOVE_HOME/END correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing up the build bot breakage. Added the keycodes to keyboard_code_conversion_android.cc Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/keyboard_code_conversion_android.cc
diff --git a/ui/events/keycodes/keyboard_code_conversion_android.cc b/ui/events/keycodes/keyboard_code_conversion_android.cc
index fa0ed31c34120a8ea0d91b1d5c5210f9ee8e2112..b7bdc830b102358d0cdc8756e345139d63dca550 100644
--- a/ui/events/keycodes/keyboard_code_conversion_android.cc
+++ b/ui/events/keycodes/keyboard_code_conversion_android.cc
@@ -21,6 +21,8 @@ enum {
AKEYCODE_META_LEFT = 117,
AKEYCODE_META_RIGHT = 118,
AKEYCODE_BREAK = 121,
+ AKEYCODE_MOVE_HOME = 122,
+ AKEYCODE_MOVE_END = 123,
AKEYCODE_INSERT = 124,
AKEYCODE_MEDIA_PLAY = 126,
AKEYCODE_MEDIA_PAUSE = 127,
@@ -80,7 +82,7 @@ KeyboardCode KeyboardCodeFromAndroidKeyCode(int keycode) {
return VKEY_ESCAPE;
case AKEYCODE_SPACE:
return VKEY_SPACE;
- case AKEYCODE_HOME:
+ case AKEYCODE_MOVE_HOME:
return VKEY_HOME;
case AKEYCODE_DPAD_LEFT:
return VKEY_LEFT;
@@ -201,7 +203,7 @@ KeyboardCode KeyboardCodeFromAndroidKeyCode(int keycode) {
case AKEYCODE_MEDIA_PLAY:
case AKEYCODE_MEDIA_PLAY_PAUSE:
return VKEY_MEDIA_PLAY_PAUSE;
- case AKEYCODE_CALL:
+ case AKEYCODE_MOVE_END:
return VKEY_END;
case AKEYCODE_ALT_LEFT:
return VKEY_LMENU;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698