dashboard/dashboard/graph_json_test.py - Issue 1549583002: In /graph_json, check internal_only on Test entity and skip test for all Row entities.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/graph_json_test.py

Issue 1549583002: In /graph_json, check internal_only on Test entity and skip test for all Row entities. (Closed) Base URL: https://github.com/catapult-project/catapult@master

Patch Set: Removed purposeful fail for local debugging Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dashboard/dashboard/graph_json_test.py

diff --git a/dashboard/dashboard/graph_json_test.py b/dashboard/dashboard/graph_json_test.py

index 5bf5d483cd388a56187e6b4954614006ec4e5869..6fbb534eba7fa825759381344991cf323ecdcae5 100644

--- a/dashboard/dashboard/graph_json_test.py

+++ b/dashboard/dashboard/graph_json_test.py

@@ -26,6 +26,7 @@ class GraphJsonTest(testing_common.TestCase):

[('/graph_json', graph_json.GraphJsonHandler)])

self.testapp = webtest.TestApp(app)

testing_common.SetInternalDomain('google.com')

+ self.PatchDatastoreHooksRequest()

# TODO(qyearsley): graph_json_test is very slow (it takes 60+ seconds

# to run sometimes), and I have a hypothesis that most of the time is

« dashboard/dashboard/graph_csv.py ('K') | « dashboard/dashboard/graph_json.py ('k') | dashboard/dashboard/graph_revisions.py » ('j') | dashboard/dashboard/graph_revisions.py » ('J')