In /graph_json, check internal_only on Test entity and skip test for all Row entities.

dashboard/dashboard/graph_csv.py

Index: dashboard/dashboard/graph_csv.py
diff --git a/dashboard/dashboard/graph_csv.py b/dashboard/dashboard/graph_csv.py
index 005753c350a0c9312b26a4d40817da46ce987194..2c280a4baf69cb9bb01ef29f52ffff2be3b14039 100644
--- a/dashboard/dashboard/graph_csv.py
+++ b/dashboard/dashboard/graph_csv.py
@@ -8,6 +8,7 @@ import csv
 import logging
 import StringIO
 
+from dashboard import datastore_hooks
 from dashboard import request_handler
 from dashboard import utils
 from dashboard.models import graph_data
@@ -40,6 +41,9 @@ class GraphCsvHandler(request_handler.RequestHandler):
     logging.info('Got request to /graph_csv for test: "%s".', test_path)
 
     test_key = utils.TestKey(test_path)
+    test = test_key.get()
+    assert(utils.IsInternalUser or not test.internal_only)

[qyearsley, 2015/12/28 22:50:56]

utils.IsInternalUser -> utils.IsInternalUser()

Possible alternate phrasing:
  assert not (test.internal_only and not utils.IsInternalUser())

(I find both of these approximately the same in terms of difficulty to
understand.)

Either way, it should be consistent with the assertion in graph_json.

[sullivan, 2015/12/29 03:36:07]

Done.

+    datastore_hooks.SetSinglePrivilegedRequest()
     q = graph_data.Row.query()
     q = q.filter(graph_data.Row.parent_test == test_key)
     if rev: