net/log/net_log.h - Issue 1549483004: Make ParametersToValue return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/net_log.h

Issue 1549483004: Make ParametersToValue return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/net_log.h

diff --git a/net/log/net_log.h b/net/log/net_log.h

index aac2e994f9a59f3a19146bf317adb8517641132a..721ddb2d15ffe6fd0e363b35715d6bceb3460988 100644

--- a/net/log/net_log.h

+++ b/net/log/net_log.h

@@ -138,7 +138,7 @@ class NET_EXPORT NetLog {

// Returns the parameters as a Value. Returns NULL if there are no

// parameters. Caller takes ownership of returned Value.

- base::Value* ParametersToValue() const;

+ scoped_ptr<base::Value> ParametersToValue() const;

mmenke 2015/12/28 16:46:39 nit: include base/memory/scoped_ptr.h

private:

const EntryData* const data_;

« no previous file with comments | « no previous file | net/log/net_log.cc » ('j') | net/log/net_log.cc » ('J')