Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: net/log/net_log.cc

Issue 1549483004: Make ParametersToValue return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log.cc
diff --git a/net/log/net_log.cc b/net/log/net_log.cc
index 4fae9e08493c9b0682757f51f77d667f96ed170d..f9d942eb0c8e229f06c45e0242b198af42d5718e 100644
--- a/net/log/net_log.cc
+++ b/net/log/net_log.cc
@@ -160,10 +160,10 @@ base::Value* NetLog::Entry::ToValue() const {
return entry_dict.release();
}
-base::Value* NetLog::Entry::ParametersToValue() const {
+scoped_ptr<base::Value> NetLog::Entry::ParametersToValue() const {
if (data_->parameters_callback)
- return data_->parameters_callback->Run(capture_mode_).release();
- return NULL;
+ return data_->parameters_callback->Run(capture_mode_);
+ return scoped_ptr<base::Value>(nullptr);
mmenke 2015/12/28 16:46:39 I think you can just do return nullptr here? If t
}
NetLog::EntryData::EntryData(EventType type,
« net/log/net_log.h ('K') | « net/log/net_log.h ('k') | net/log/test_net_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698