Make ParametersToValue return scoped_ptr

Make ParametersToValue return scoped_ptr

Almost all consumers use already scoped_ptr
and one place is much simpler when changed to use scoped_ptr.

Committed: https://crrev.com/0a833f796cf9393f6a36e4d10cd69f79856fecce
Cr-Commit-Position: refs/heads/master@{#367062}

[Olli Raula, 2015-12-28 06:47:33]

Description was changed from

==========
Make ParametersToValue return scoped_ptr

Almost all consumers already use scoped_ptr already
and one place is much simpler when changed to use scoped_ptr.
==========

to

==========
Make ParametersToValue return scoped_ptr

Almost all consumers use already scoped_ptr
and one place is much simpler when changed to use scoped_ptr.
==========

[Olli Raula, 2015-12-28 06:50:35]

olli.raula@intel.com changed reviewers:
+ mmenke@chromium.org

[Olli Raula, 2015-12-28 06:50:53]

Could you review this when you are back.

[mmenke, 2015-12-28 16:46:39]

LGTM, thanks for doing this!

https://codereview.chromium.org/1549483004/diff/1/net/log/net_log.cc
File net/log/net_log.cc (right):

https://codereview.chromium.org/1549483004/diff/1/net/log/net_log.cc#newcode166
net/log/net_log.cc:166: return scoped_ptr<base::Value>(nullptr);
I think you can just do return nullptr here?  If that doesn't work,, you can
just remove the nullptr - scoped_ptr has a 0-argument constructor.

https://codereview.chromium.org/1549483004/diff/1/net/log/net_log.h
File net/log/net_log.h (right):

https://codereview.chromium.org/1549483004/diff/1/net/log/net_log.h#newcode141
net/log/net_log.h:141: scoped_ptr<base::Value> ParametersToValue() const;
nit: include base/memory/scoped_ptr.h

[Olli Raula, 2015-12-29 11:33:21]

The CQ bit was checked by olli.raula@intel.com

[Olli Raula, 2015-12-29 11:33:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1549483004/#ps20001
(title: "Fix")

[commit-bot: I haz the power, 2015-12-29 11:33:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549483004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549483004/20001

[commit-bot: I haz the power, 2015-12-29 12:49:33]

Description was changed from

==========
Make ParametersToValue return scoped_ptr

Almost all consumers use already scoped_ptr
and one place is much simpler when changed to use scoped_ptr.
==========

to

==========
Make ParametersToValue return scoped_ptr

Almost all consumers use already scoped_ptr
and one place is much simpler when changed to use scoped_ptr.
==========

[commit-bot: I haz the power, 2015-12-29 12:49:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-29 12:50:37]

Description was changed from

==========
Make ParametersToValue return scoped_ptr

Almost all consumers use already scoped_ptr
and one place is much simpler when changed to use scoped_ptr.
==========

to

==========
Make ParametersToValue return scoped_ptr

Almost all consumers use already scoped_ptr
and one place is much simpler when changed to use scoped_ptr.

Committed: https://crrev.com/0a833f796cf9393f6a36e4d10cd69f79856fecce
Cr-Commit-Position: refs/heads/master@{#367062}
==========

[commit-bot: I haz the power, 2015-12-29 12:50:37]

Patchset 2 (id:??) landed as
https://crrev.com/0a833f796cf9393f6a36e4d10cd69f79856fecce
Cr-Commit-Position: refs/heads/master@{#367062}