Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/log/net_log.cc

Issue 1549483004: Make ParametersToValue return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/log/net_log.h ('k') | net/log/test_net_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/net_log.cc
diff --git a/net/log/net_log.cc b/net/log/net_log.cc
index 90ec6a0ea34e9720c2b207ce4a3d69a6e53f6db1..a3fde00814194e666da4b5918b4bebc6d7512632 100644
--- a/net/log/net_log.cc
+++ b/net/log/net_log.cc
@@ -162,10 +162,10 @@ base::Value* NetLog::Entry::ToValue() const {
return entry_dict.release();
}
-base::Value* NetLog::Entry::ParametersToValue() const {
+scoped_ptr<base::Value> NetLog::Entry::ParametersToValue() const {
if (data_->parameters_callback)
- return data_->parameters_callback->Run(capture_mode_).release();
- return NULL;
+ return data_->parameters_callback->Run(capture_mode_);
+ return nullptr;
}
NetLog::EntryData::EntryData(EventType type,
« no previous file with comments | « net/log/net_log.h ('k') | net/log/test_net_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698