chrome/browser/extensions/api/feedback_private/feedback_service.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_private_api.cc ('k') | chrome/browser/extensions/api/gcd_private/gcd_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_service.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service.cc b/chrome/browser/extensions/api/feedback_private/feedback_service.cc

index 33efea8a537469f307c0d8917c2b0d383e4a8d8d..28a72c6b9329ac0d3cbefbe64b148e5a48487a93 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_service.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_service.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/feedback_private/feedback_service.h"

+#include <utility>

#include "base/callback.h"

#include "base/memory/weak_ptr.h"

#include "base/strings/string_number_conversions.h"

@@ -73,7 +75,7 @@ void FeedbackService::AttachedFileCallback(scoped_ptr<std::string> data,

int64_t /* total_blob_length */) {

feedback_data_->set_attached_file_uuid(std::string());

if (data)

- feedback_data_->AttachAndCompressFileData(data.Pass());

+ feedback_data_->AttachAndCompressFileData(std::move(data));

CompleteSendFeedback();

}

@@ -82,7 +84,7 @@ void FeedbackService::ScreenshotCallback(scoped_ptr<std::string> data,

int64_t /* total_blob_length */) {

feedback_data_->set_screenshot_uuid(std::string());

if (data)

- feedback_data_->set_image(data.Pass());

+ feedback_data_->set_image(std::move(data));

CompleteSendFeedback();

}