Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index b0ce1d997b384883560cbd9244dda501b2c3fc54..16ee81aba4b028f562d77eeed423a3441aa1da87 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h"
+#include <utility>
+
#include "base/lazy_instance.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
@@ -92,11 +94,11 @@ void FeedbackPrivateAPI::RequestFeedback(
scoped_ptr<Event> event(new Event(
events::FEEDBACK_PRIVATE_ON_FEEDBACK_REQUESTED,
- feedback_private::OnFeedbackRequested::kEventName, args.Pass()));
+ feedback_private::OnFeedbackRequested::kEventName, std::move(args)));
event->restrict_to_browser_context = browser_context_;
EventRouter::Get(browser_context_)
- ->DispatchEventToExtension(kFeedbackExtensionId, event.Pass());
+ ->DispatchEventToExtension(kFeedbackExtensionId, std::move(event));
}
}
@@ -216,7 +218,7 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() {
it != sys_info->end(); ++it)
(*sys_logs.get())[it->get()->key] = it->get()->value;
}
- feedback_data->SetAndCompressSystemInfo(sys_logs.Pass());
+ feedback_data->SetAndCompressSystemInfo(std::move(sys_logs));
FeedbackService* service =
FeedbackPrivateAPI::GetFactoryInstance()->Get(GetProfile())->GetService();
@@ -226,7 +228,7 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() {
scoped_ptr<std::string> histograms(new std::string);
*histograms = base::StatisticsRecorder::ToJSON(std::string());
if (!histograms->empty())
- feedback_data->SetAndCompressHistograms(histograms.Pass());
+ feedback_data->SetAndCompressHistograms(std::move(histograms));
}
service->SendFeedback(

Powered by Google App Engine
This is Rietveld 408576698