chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc ('k') | chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

index fcbe071b0d17fc78441644a0e19e1d087987faf3..3715a5c6e440e5d4bfcbf92c50f0939fc5db492b 100644

--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

@@ -6,6 +6,7 @@

#include <stddef.h>

#include <stdint.h>

+#include <utility>

#include "base/lazy_instance.h"

#include "base/prefs/pref_service.h"

@@ -92,9 +93,9 @@ void ActivityLogAPI::OnExtensionActivity(scoped_refptr<Action> activity) {

value->Append(activity_arg->ToValue().release());

scoped_ptr<Event> event(new Event(

events::ACTIVITY_LOG_PRIVATE_ON_EXTENSION_ACTIVITY,

- activity_log_private::OnExtensionActivity::kEventName, value.Pass()));

+ activity_log_private::OnExtensionActivity::kEventName, std::move(value)));

event->restrict_to_browser_context = browser_context_;

- EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass());

+ EventRouter::Get(browser_context_)->BroadcastEvent(std::move(event));

}

bool ActivityLogPrivateGetExtensionActivitiesFunction::RunAsync() {