Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/activity_log_private/activity_log_privat e_api.h" 5 #include "chrome/browser/extensions/api/activity_log_private/activity_log_privat e_api.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility>
9 10
10 #include "base/lazy_instance.h" 11 #include "base/lazy_instance.h"
11 #include "base/prefs/pref_service.h" 12 #include "base/prefs/pref_service.h"
12 #include "base/strings/string_number_conversions.h" 13 #include "base/strings/string_number_conversions.h"
13 #include "base/values.h" 14 #include "base/values.h"
14 #include "chrome/browser/browser_process.h" 15 #include "chrome/browser/browser_process.h"
15 #include "chrome/browser/extensions/event_router_forwarder.h" 16 #include "chrome/browser/extensions/event_router_forwarder.h"
16 #include "chrome/browser/extensions/extension_service.h" 17 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/common/extensions/api/activity_log_private.h" 18 #include "chrome/common/extensions/api/activity_log_private.h"
18 #include "content/public/browser/browser_context.h" 19 #include "content/public/browser/browser_context.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 // TODO(felt): Only observe activity_log_ events when we have a customer. 86 // TODO(felt): Only observe activity_log_ events when we have a customer.
86 } 87 }
87 88
88 void ActivityLogAPI::OnExtensionActivity(scoped_refptr<Action> activity) { 89 void ActivityLogAPI::OnExtensionActivity(scoped_refptr<Action> activity) {
89 scoped_ptr<base::ListValue> value(new base::ListValue()); 90 scoped_ptr<base::ListValue> value(new base::ListValue());
90 scoped_ptr<ExtensionActivity> activity_arg = 91 scoped_ptr<ExtensionActivity> activity_arg =
91 activity->ConvertToExtensionActivity(); 92 activity->ConvertToExtensionActivity();
92 value->Append(activity_arg->ToValue().release()); 93 value->Append(activity_arg->ToValue().release());
93 scoped_ptr<Event> event(new Event( 94 scoped_ptr<Event> event(new Event(
94 events::ACTIVITY_LOG_PRIVATE_ON_EXTENSION_ACTIVITY, 95 events::ACTIVITY_LOG_PRIVATE_ON_EXTENSION_ACTIVITY,
95 activity_log_private::OnExtensionActivity::kEventName, value.Pass())); 96 activity_log_private::OnExtensionActivity::kEventName, std::move(value)));
96 event->restrict_to_browser_context = browser_context_; 97 event->restrict_to_browser_context = browser_context_;
97 EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass()); 98 EventRouter::Get(browser_context_)->BroadcastEvent(std::move(event));
98 } 99 }
99 100
100 bool ActivityLogPrivateGetExtensionActivitiesFunction::RunAsync() { 101 bool ActivityLogPrivateGetExtensionActivitiesFunction::RunAsync() {
101 scoped_ptr<activity_log_private::GetExtensionActivities::Params> params( 102 scoped_ptr<activity_log_private::GetExtensionActivities::Params> params(
102 activity_log_private::GetExtensionActivities::Params::Create(*args_)); 103 activity_log_private::GetExtensionActivities::Params::Create(*args_));
103 EXTENSION_FUNCTION_VALIDATE(params.get()); 104 EXTENSION_FUNCTION_VALIDATE(params.get());
104 105
105 // Get the arguments in the right format. 106 // Get the arguments in the right format.
106 scoped_ptr<Filter> filter; 107 scoped_ptr<Filter> filter;
107 filter.reset(&params.release()->filter); 108 filter.reset(&params.release()->filter);
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 gurls.push_back(GURL(*it)); 219 gurls.push_back(GURL(*it));
219 } 220 }
220 221
221 ActivityLog* activity_log = ActivityLog::GetInstance(GetProfile()); 222 ActivityLog* activity_log = ActivityLog::GetInstance(GetProfile());
222 DCHECK(activity_log); 223 DCHECK(activity_log);
223 activity_log->RemoveURLs(gurls); 224 activity_log->RemoveURLs(gurls);
224 return true; 225 return true;
225 } 226 }
226 227
227 } // namespace extensions 228 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698