Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1549133002: X87: [TurboFan] Increase SP Delta when the operand of kX87Push is in double register. (Closed)

Created:
4 years, 12 months ago by zhengxing.li
Modified:
4 years, 12 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [TurboFan] Increase SP Delta when the operand of kX87Push is in double register. As the operand in double register is put into stack, the SP delta should be increased too similar to the operand of kX87Push is in double slot of stack. BUG= Committed: https://crrev.com/fa98795500b9fa6eaf993ebf50c9b4b56c2a5e32 Cr-Commit-Position: refs/heads/master@{#33045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 12 months ago (2015-12-25 08:03:50 UTC) #2
Weiliang
lgtm
4 years, 12 months ago (2015-12-28 05:57:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549133002/1
4 years, 12 months ago (2015-12-28 05:57:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 06:15:43 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 06:16:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa98795500b9fa6eaf993ebf50c9b4b56c2a5e32
Cr-Commit-Position: refs/heads/master@{#33045}

Powered by Google App Engine
This is Rietveld 408576698