Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: src/compiler/x87/code-generator-x87.cc

Issue 1549133002: X87: [TurboFan] Increase SP Delta when the operand of kX87Push is in double register. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 1249 matching lines...) Expand 10 before | Expand all | Expand 10 after
1260 if (instr->InputAt(0)->IsDoubleRegister()) { 1260 if (instr->InputAt(0)->IsDoubleRegister()) {
1261 auto allocated = AllocatedOperand::cast(*instr->InputAt(0)); 1261 auto allocated = AllocatedOperand::cast(*instr->InputAt(0));
1262 if (allocated.representation() == MachineRepresentation::kFloat32) { 1262 if (allocated.representation() == MachineRepresentation::kFloat32) {
1263 __ sub(esp, Immediate(kDoubleSize)); 1263 __ sub(esp, Immediate(kDoubleSize));
1264 __ fst_s(Operand(esp, 0)); 1264 __ fst_s(Operand(esp, 0));
1265 } else { 1265 } else {
1266 DCHECK(allocated.representation() == MachineRepresentation::kFloat64); 1266 DCHECK(allocated.representation() == MachineRepresentation::kFloat64);
1267 __ sub(esp, Immediate(kDoubleSize)); 1267 __ sub(esp, Immediate(kDoubleSize));
1268 __ fst_d(Operand(esp, 0)); 1268 __ fst_d(Operand(esp, 0));
1269 } 1269 }
1270 frame_access_state()->IncreaseSPDelta(kDoubleSize / kPointerSize);
1270 } else if (instr->InputAt(0)->IsDoubleStackSlot()) { 1271 } else if (instr->InputAt(0)->IsDoubleStackSlot()) {
1271 auto allocated = AllocatedOperand::cast(*instr->InputAt(0)); 1272 auto allocated = AllocatedOperand::cast(*instr->InputAt(0));
1272 if (allocated.representation() == MachineRepresentation::kFloat32) { 1273 if (allocated.representation() == MachineRepresentation::kFloat32) {
1273 __ sub(esp, Immediate(kDoubleSize)); 1274 __ sub(esp, Immediate(kDoubleSize));
1274 __ fld_s(i.InputOperand(0)); 1275 __ fld_s(i.InputOperand(0));
1275 __ fstp_s(MemOperand(esp, 0)); 1276 __ fstp_s(MemOperand(esp, 0));
1276 } else { 1277 } else {
1277 DCHECK(allocated.representation() == MachineRepresentation::kFloat64); 1278 DCHECK(allocated.representation() == MachineRepresentation::kFloat64);
1278 __ sub(esp, Immediate(kDoubleSize)); 1279 __ sub(esp, Immediate(kDoubleSize));
1279 __ fld_d(i.InputOperand(0)); 1280 __ fld_d(i.InputOperand(0));
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
2002 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 2003 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
2003 __ Nop(padding_size); 2004 __ Nop(padding_size);
2004 } 2005 }
2005 } 2006 }
2006 2007
2007 #undef __ 2008 #undef __
2008 2009
2009 } // namespace compiler 2010 } // namespace compiler
2010 } // namespace internal 2011 } // namespace internal
2011 } // namespace v8 2012 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698