Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1549053002: Remove an unneeded OS!=win now that update.py is used. (Closed)

Created:
4 years, 12 months ago by Nico
Modified:
4 years, 12 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., Lei Zhang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove an unneeded OS!=win now that update.py is used. Follow-up to https://codereview.chromium.org/1495653002, and makes it easier to maybe have a clang/win build of v8 at some point in the future. BUG=none LOG=n Committed: https://crrev.com/25864f2d001db4eaeb850139d28555775860b5a4 Cr-Commit-Position: refs/heads/master@{#33037}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 12 months ago (2015-12-24 04:27:24 UTC) #2
Michael Achenbach
lgtm
4 years, 12 months ago (2015-12-24 09:21:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549053002/20001
4 years, 12 months ago (2015-12-24 11:57:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-24 11:58:24 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 11:58:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25864f2d001db4eaeb850139d28555775860b5a4
Cr-Commit-Position: refs/heads/master@{#33037}

Powered by Google App Engine
This is Rietveld 408576698