Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1495653002: Let v8 standalone builds use update.py instead of update.sh. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Let v8 standalone builds use update.py instead of update.sh. update.sh is gone in chromium, and using update.py will do the right thing both before and after the deletion in chromium (previously, update.py used to call update.sh internally on non-win). This also has the benefit of working on Windows. No intended behavior change. BUG=chromium:494442 LOG=n Committed: https://crrev.com/39bef217a39cc097cf6057a9a9706aa440f75cfe Cr-Commit-Position: refs/heads/master@{#32529}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
5 years ago (2015-12-02 18:35:17 UTC) #2
Michael Achenbach
lgtm
5 years ago (2015-12-02 20:11:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495653002/20001
5 years ago (2015-12-02 20:11:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 20:25:49 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 20:28:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39bef217a39cc097cf6057a9a9706aa440f75cfe
Cr-Commit-Position: refs/heads/master@{#32529}

Powered by Google App Engine
This is Rietveld 408576698