Simplify PDFiumEngine::GetFlattenedPrintData().

Simplify PDFiumEngine::GetFlattenedPrintData().

Committed: https://crrev.com/a45c0ddbd45a6a38f7a71d29304ceb8eb0a63222
Cr-Commit-Position: refs/heads/master@{#367370}

[Lei Zhang, 2015-12-24 08:00:55]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[Lei Zhang, 2015-12-24 08:00:56]

(No rush)

https://codereview.chromium.org/1549013003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (left):

https://codereview.chromium.org/1549013003/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:1464: FPDF_CloseDocument(doc);
No need, all the callers do it.

[raymes, 2016-01-04 00:19:56]

lgtm

https://codereview.chromium.org/1549013003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1549013003/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:1452: return buffer;
I think we should probably remove the if (!page) check or else remove the DCHECK
above it, as per
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...

[Lei Zhang, 2016-01-04 20:03:03]

https://codereview.chromium.org/1549013003/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1549013003/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:1452: return buffer;
On 2016/01/04 00:19:56, raymes wrote:
> I think we should probably remove the if (!page) check or else remove the
DCHECK
> above it, as per
>
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...

Done.

[Lei Zhang, 2016-01-04 20:25:56]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-01-04 20:25:57]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1549013003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-01-04 20:27:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549013003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549013003/40001

[commit-bot: I haz the power, 2016-01-04 21:18:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-04 21:19:38]

Description was changed from

==========
Simplify PDFiumEngine::GetFlattenedPrintData().
==========

to

==========
Simplify PDFiumEngine::GetFlattenedPrintData().

Committed: https://crrev.com/a45c0ddbd45a6a38f7a71d29304ceb8eb0a63222
Cr-Commit-Position: refs/heads/master@{#367370}
==========

[commit-bot: I haz the power, 2016-01-04 21:19:39]

Patchset 3 (id:??) landed as
https://crrev.com/a45c0ddbd45a6a38f7a71d29304ceb8eb0a63222
Cr-Commit-Position: refs/heads/master@{#367370}