Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 1549013003: Simplify PDFiumEngine::GetFlattenedPrintData(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_engine.cc
diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc
index 6506d8c96b1038af85ffed479c6b7d05e9dcb8c1..14bbb4e84384120bae9b0bf88141277e4e2c9e73 100644
--- a/pdf/pdfium/pdfium_engine.cc
+++ b/pdf/pdfium/pdfium_engine.cc
@@ -1445,29 +1445,17 @@ pp::Buffer_Dev PDFiumEngine::PrintPagesAsRasterPDF(
}
pp::Buffer_Dev PDFiumEngine::GetFlattenedPrintData(const FPDF_DOCUMENT& doc) {
+ pp::Buffer_Dev buffer;
int page_count = FPDF_GetPageCount(doc);
- bool flatten_succeeded = true;
for (int i = 0; i < page_count; ++i) {
FPDF_PAGE page = FPDF_LoadPage(doc, i);
DCHECK(page);
- if (page) {
- int flatten_ret = FPDFPage_Flatten(page, FLAT_PRINT);
- FPDF_ClosePage(page);
- if (flatten_ret == FLATTEN_FAIL) {
- flatten_succeeded = false;
- break;
- }
- } else {
- flatten_succeeded = false;
- break;
- }
- }
- if (!flatten_succeeded) {
- FPDF_CloseDocument(doc);
- return pp::Buffer_Dev();
+ int flatten_ret = FPDFPage_Flatten(page, FLAT_PRINT);
+ FPDF_ClosePage(page);
+ if (flatten_ret == FLATTEN_FAIL)
+ return buffer;
}
- pp::Buffer_Dev buffer;
PDFiumMemBufferFileWrite output_file_write;
if (FPDF_SaveAsCopy(doc, &output_file_write, 0)) {
buffer = pp::Buffer_Dev(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698