Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549003002: Switch to standard integer types in base/memory/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/memory/. BUG=138542 TBR=mark@chromium.org Committed: https://crrev.com/9beac25f9447dd40cc132df1160feb91822181b8 Cr-Commit-Position: refs/heads/master@{#366816}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -94 lines) Patch
M base/memory/aligned_memory.h View 2 chunks +23 lines, -20 lines 0 comments Download
M base/memory/aligned_memory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/aligned_memory_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/discardable_memory.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/discardable_memory_allocator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/memory/discardable_shared_memory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 12 chunks +14 lines, -13 lines 0 comments Download
M base/memory/memory_pressure_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/memory_pressure_monitor.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/memory_pressure_monitor_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/memory_pressure_monitor_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/memory_pressure_monitor_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/memory_pressure_monitor_mac_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/memory_pressure_monitor_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/memory_pressure_monitor_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/ptr_util_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/memory/ref_counted.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/ref_counted_delete_on_message_loop.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/ref_counted_memory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/memory/ref_counted_memory_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/memory/scoped_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/scoped_ptr_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M base/memory/scoped_vector.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/memory/scoped_vector_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/shared_memory.h View 1 chunk +6 lines, -8 lines 0 comments Download
M base/memory/shared_memory_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/shared_memory_handle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/memory/shared_memory_mac_unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M base/memory/shared_memory_nacl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 2 15 chunks +23 lines, -19 lines 0 comments Download
M base/memory/shared_memory_win.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M base/memory/singleton.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/singleton_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/memory/weak_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/risk_util.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/risk_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_interface.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/content_settings/core/browser/website_settings_info.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M components/content_settings/core/browser/website_settings_info.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/common/scoped_drm_types.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1550503002 Patch 60001

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549003002/1
5 years ago (2015-12-24 03:21:13 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/96360) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-24 03:35:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549003002/20001
5 years ago (2015-12-24 03:51:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/73823)
5 years ago (2015-12-24 04:07:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549003002/40001
5 years ago (2015-12-24 04:34:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/73805)
5 years ago (2015-12-24 05:11:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549003002/60001
5 years ago (2015-12-24 05:20:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/73834)
5 years ago (2015-12-24 06:09:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549003002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549003002/80001
5 years ago (2015-12-24 06:17:49 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/123857)
5 years ago (2015-12-24 07:09:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1549003002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1549003002/100001
5 years ago (2015-12-24 07:15:05 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 12 months ago (2015-12-24 08:45:10 UTC) #23
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 08:46:13 UTC) #25
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/9beac25f9447dd40cc132df1160feb91822181b8
Cr-Commit-Position: refs/heads/master@{#366816}

Powered by Google App Engine
This is Rietveld 408576698