Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1548873002: Port CSS visibility animations to CSSInterpolationTypes (Closed)

Created:
5 years ago by alancutter (OOO until 2018)
Modified:
4 years, 11 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port CSS visibility animations to CSSInterpolationTypes This change refactors CSS visibility animations to use CSSInterpolationType. There is no difference in behaviour in this patch. BUG=530436 Committed: https://crrev.com/fb1422557db007628645794f066fae877ad558ca Cr-Commit-Position: refs/heads/master@{#368546}

Patch Set 1 #

Patch Set 2 : Added deferred interpolation comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/animations/responsive/visibility-responsive.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/stacked-visibility-animations-responsive.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.h View 1 chunk +12 lines, -12 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp View 1 1 chunk +177 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
alancutter (OOO until 2018)
5 years ago (2015-12-23 08:32:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548873002/1
5 years ago (2015-12-23 08:32:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-23 09:53:26 UTC) #6
dstockwell
lgtm The special case of interpolation happening in the NIV warrants some comments.
4 years, 11 months ago (2016-01-03 22:12:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548873002/20001
4 years, 11 months ago (2016-01-11 03:53:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 09:13:50 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 09:16:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb1422557db007628645794f066fae877ad558ca
Cr-Commit-Position: refs/heads/master@{#368546}

Powered by Google App Engine
This is Rietveld 408576698