third_party/WebKit/Source/core/animation/StringKeyframe.cpp - Issue 1548873002: Port CSS visibility animations to CSSInterpolationTypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

Issue 1548873002: Port CSS visibility animations to CSSInterpolationTypes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added deferred interpolation comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

index b348b1952037fe611f46a16270c090daefc7fafd..3ea0b7078f539de509f1d4880dfd23995c07ea8d 100644

--- a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

@@ -15,6 +15,7 @@

#include "core/animation/CSSPaintInterpolationType.h"

#include "core/animation/CSSShadowListInterpolationType.h"

#include "core/animation/CSSValueInterpolationType.h"

+#include "core/animation/CSSVisibilityInterpolationType.h"

#include "core/animation/CompositorAnimations.h"

#include "core/animation/ConstantStyleInterpolation.h"

#include "core/animation/DefaultSVGInterpolation.h"

@@ -260,6 +261,9 @@ const InterpolationTypes* applicableTypesForProperty(PropertyHandle property)

case CSSPropertyFontWeight:

applicableTypes->append(adoptPtr(new CSSFontWeightInterpolationType(cssProperty)));

break;

+ case CSSPropertyVisibility:

+ applicableTypes->append(adoptPtr(new CSSVisibilityInterpolationType(cssProperty)));

+ break;

default:

// TODO(alancutter): Support all interpolable CSS properties here so we can stop falling back to the old StyleInterpolation implementation.

if (CSSPropertyMetadata::isInterpolableProperty(cssProperty))