Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1548523002: Use Document, rather than document element, for implicit root. (Closed)

Created:
5 years ago by szager1
Modified:
4 years, 11 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src@intersection-observer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Document, rather than document element, for implicit root. To land after: https://codereview.chromium.org/1449623002/ BUG=570538 R=esprehn@chromium.org,ojan@chromium.org Committed: https://crrev.com/4275523d593c4932fe5c66c12020545cb08c3b0a Cr-Commit-Position: refs/heads/master@{#369073}

Patch Set 1 #

Patch Set 2 : rebaseline #

Patch Set 3 : rebaseline #

Patch Set 4 : rebaseline #

Total comments: 4

Patch Set 5 : Nits, comments, rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -222 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 3 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.h View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp View 1 2 3 4 1 chunk +0 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.h View 1 2 3 4 3 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 1 2 3 4 6 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 2 3 4 5 chunks +23 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.h View 1 2 1 chunk +13 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.cpp View 1 2 3 4 4 chunks +26 lines, -20 lines 0 comments Download

Depends on Patchset:

Issue 1559593002 Patch 120001

Messages

Total messages: 12 (2 generated)
szager1
5 years ago (2015-12-21 22:02:38 UTC) #1
szager1
ping
4 years, 11 months ago (2016-01-08 23:54:35 UTC) #2
ojan
Patch mostly looks good. This changes behavior though, right? I think you need a test ...
4 years, 11 months ago (2016-01-12 01:28:18 UTC) #3
szager1
https://codereview.chromium.org/1548523002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right): https://codereview.chromium.org/1548523002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp#newcode28 third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:28: return toElement(m_target.get()); On 2016/01/12 01:28:18, ojan wrote: > How ...
4 years, 11 months ago (2016-01-12 21:19:51 UTC) #4
ojan
lgtm
4 years, 11 months ago (2016-01-13 00:41:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548523002/80001
4 years, 11 months ago (2016-01-13 00:42:55 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-13 02:13:42 UTC) #8
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/4275523d593c4932fe5c66c12020545cb08c3b0a Cr-Commit-Position: refs/heads/master@{#369073}
4 years, 11 months ago (2016-01-13 02:14:37 UTC) #10
kinuko
Looks like this broke oilpan build.
4 years, 11 months ago (2016-01-13 03:01:56 UTC) #11
Peter Kasting
4 years, 11 months ago (2016-01-13 03:33:51 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1580783003/ by pkasting@chromium.org.

The reason for reverting is: Broke Linux Oilpan build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan....

Powered by Google App Engine
This is Rietveld 408576698