Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.h

Issue 1548523002: Use Document, rather than document element, for implicit root. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer
Patch Set: Nits, comments, rebaseline Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IntersectionObservation_h 5 #ifndef IntersectionObservation_h
6 #define IntersectionObservation_h 6 #define IntersectionObservation_h
7 7
8 #include "platform/geometry/LayoutRect.h" 8 #include "platform/geometry/LayoutRect.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 class Element; 13 class Element;
14 class IntersectionObserver; 14 class IntersectionObserver;
15 class Node;
15 16
16 class IntersectionObservation : public GarbageCollectedFinalized<IntersectionObs ervation> { 17 class IntersectionObservation : public GarbageCollectedFinalized<IntersectionObs ervation> {
17 public: 18 public:
18 IntersectionObservation(IntersectionObserver&, Element&, bool shouldReportRo otBounds); 19 IntersectionObservation(IntersectionObserver&, Element&, bool shouldReportRo otBounds);
19 20
20 struct IntersectionGeometry { 21 struct IntersectionGeometry {
21 LayoutRect targetRect; 22 LayoutRect targetRect;
22 LayoutRect intersectionRect; 23 LayoutRect intersectionRect;
23 LayoutRect rootRect; 24 LayoutRect rootRect;
24 }; 25 };
25 26
26 IntersectionObserver& observer() const { return *m_observer; } 27 IntersectionObserver& observer() const { return *m_observer; }
27 Element* target() const { return m_target.get(); } 28 Element* target() const;
28 bool isActive() const { return m_active; } 29 bool isActive() const { return m_active; }
29 void setActive(bool active) { m_active = active; } 30 void setActive(bool active) { m_active = active; }
30 unsigned lastThresholdIndex() const { return m_lastThresholdIndex; } 31 unsigned lastThresholdIndex() const { return m_lastThresholdIndex; }
31 void setLastThresholdIndex(unsigned index) { m_lastThresholdIndex = index; } 32 void setLastThresholdIndex(unsigned index) { m_lastThresholdIndex = index; }
32 bool shouldReportRootBounds() const { return m_shouldReportRootBounds; } 33 bool shouldReportRootBounds() const { return m_shouldReportRootBounds; }
33 34
34 void computeIntersectionObservations(double timestamp); 35 void computeIntersectionObservations(double timestamp);
35 void disconnect(); 36 void disconnect();
36 37
37 DECLARE_TRACE(); 38 DECLARE_TRACE();
38 39
39 private: 40 private:
40 void initializeGeometry(IntersectionGeometry&); 41 void initializeGeometry(IntersectionGeometry&);
41 void clipToRoot(LayoutRect&); 42 void clipToRoot(LayoutRect&);
42 void clipToFrameView(IntersectionGeometry&); 43 void clipToFrameView(IntersectionGeometry&);
43 bool computeGeometry(IntersectionGeometry&); 44 bool computeGeometry(IntersectionGeometry&);
44 45
45 Member<IntersectionObserver> m_observer; 46 Member<IntersectionObserver> m_observer;
46 WeakPtrWillBeWeakMember<Element> m_target; 47
48 // TODO(szager): Why Node instead of Element? Because NodeIntersectionObser verData::createWeakPtr()
49 // returns a WeakPtr<Node>, which cannot be coerced into a WeakPtr<Element>. When oilpan rolls out,
50 // this can be changed to WeakMember<Element>.
51 WeakPtrWillBeWeakMember<Node> m_target;
52
47 unsigned m_active : 1; 53 unsigned m_active : 1;
48 unsigned m_shouldReportRootBounds : 1; 54 unsigned m_shouldReportRootBounds : 1;
49 unsigned m_lastThresholdIndex : 30; 55 unsigned m_lastThresholdIndex : 30;
50 }; 56 };
51 57
52 } // namespace blink 58 } // namespace blink
53 59
54 #endif // IntersectionObservation_h 60 #endif // IntersectionObservation_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/ElementRareData.h ('k') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698