gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained

Patch Set: Addressed CR feedback from Daniel. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.h ('k') | gpu/command_buffer/service/in_process_command_buffer.h » ('j') | gpu/ipc/gpu_command_buffer_traits.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index 81ce57d33e66dd0e5f6af5722932c30aebf264c1..699017ecc46964a0077cc4b5405e902076713d1f 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -12657,7 +12657,8 @@ error::Error GLES2DecoderImpl::HandleWaitSyncTokenCHROMIUM(

(c.namespace_id < static_cast<int32_t>(kMaxNamespaceId)))

? static_cast<gpu::CommandBufferNamespace>(c.namespace_id)

: gpu::CommandBufferNamespace::INVALID;

- const uint64_t command_buffer_id = c.command_buffer_id();

+ const CommandBufferId command_buffer_id =

+ CommandBufferId::FromUnsafeValue(c.command_buffer_id());

const uint64_t release = c.release_count();

if (wait_fence_sync_callback_.is_null())

return error::kNoError;