Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1548443002: Introducing gpu::CommandBufferId as a distinct, IdType<...>-based type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-save-package-id-self-contained
Patch Set: Addressed CR feedback from Daniel. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 #include <stdio.h> 10 #include <stdio.h>
(...skipping 12639 matching lines...) Expand 10 before | Expand all | Expand 10 after
12650 const gpu::CommandBufferNamespace kMinNamespaceId = 12650 const gpu::CommandBufferNamespace kMinNamespaceId =
12651 gpu::CommandBufferNamespace::INVALID; 12651 gpu::CommandBufferNamespace::INVALID;
12652 const gpu::CommandBufferNamespace kMaxNamespaceId = 12652 const gpu::CommandBufferNamespace kMaxNamespaceId =
12653 gpu::CommandBufferNamespace::NUM_COMMAND_BUFFER_NAMESPACES; 12653 gpu::CommandBufferNamespace::NUM_COMMAND_BUFFER_NAMESPACES;
12654 12654
12655 const gpu::CommandBufferNamespace namespace_id = 12655 const gpu::CommandBufferNamespace namespace_id =
12656 ((c.namespace_id >= static_cast<int32_t>(kMinNamespaceId)) && 12656 ((c.namespace_id >= static_cast<int32_t>(kMinNamespaceId)) &&
12657 (c.namespace_id < static_cast<int32_t>(kMaxNamespaceId))) 12657 (c.namespace_id < static_cast<int32_t>(kMaxNamespaceId)))
12658 ? static_cast<gpu::CommandBufferNamespace>(c.namespace_id) 12658 ? static_cast<gpu::CommandBufferNamespace>(c.namespace_id)
12659 : gpu::CommandBufferNamespace::INVALID; 12659 : gpu::CommandBufferNamespace::INVALID;
12660 const uint64_t command_buffer_id = c.command_buffer_id(); 12660 const CommandBufferId command_buffer_id =
12661 CommandBufferId::FromUnsafeValue(c.command_buffer_id());
12661 const uint64_t release = c.release_count(); 12662 const uint64_t release = c.release_count();
12662 if (wait_fence_sync_callback_.is_null()) 12663 if (wait_fence_sync_callback_.is_null())
12663 return error::kNoError; 12664 return error::kNoError;
12664 12665
12665 return wait_fence_sync_callback_.Run(namespace_id, command_buffer_id, release) 12666 return wait_fence_sync_callback_.Run(namespace_id, command_buffer_id, release)
12666 ? error::kNoError 12667 ? error::kNoError
12667 : error::kDeferCommandUntilLater; 12668 : error::kDeferCommandUntilLater;
12668 } 12669 }
12669 12670
12670 error::Error GLES2DecoderImpl::HandleDiscardBackbufferCHROMIUM( 12671 error::Error GLES2DecoderImpl::HandleDiscardBackbufferCHROMIUM(
(...skipping 2954 matching lines...) Expand 10 before | Expand all | Expand 10 after
15625 } 15626 }
15626 15627
15627 // Include the auto-generated part of this file. We split this because it means 15628 // Include the auto-generated part of this file. We split this because it means
15628 // we can easily edit the non-auto generated parts right here in this file 15629 // we can easily edit the non-auto generated parts right here in this file
15629 // instead of having to edit some template or the code generator. 15630 // instead of having to edit some template or the code generator.
15630 #include "base/macros.h" 15631 #include "base/macros.h"
15631 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h" 15632 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
15632 15633
15633 } // namespace gles2 15634 } // namespace gles2
15634 } // namespace gpu 15635 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698