Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1548363003:
[crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. (Closed)
|
Created:
4 years, 11 months ago by Igor Sheludko Modified:
4 years, 11 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject.
BUG=chromium:571064
LOG=Y
TBR=jkummerow@chromium.org
Committed: https://crrev.com/bae0d6c8dccbff5bd1c21d3d81315b14649e3a9b
Cr-Commit-Position: refs/heads/master@{#33058}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== [crankshaft] Don't inline array resize operation if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y ========== to ========== [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y ==========
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548363003/1
ishell@chromium.org changed reviewers: + cbruni@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548363003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9319)
Description was changed from ========== [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y ========== to ========== [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y TBR=jkummerow@chromium.org ==========
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548363003/1
ishell@chromium.org changed reviewers: + jkummerow@chromium.org
Jakob, PTAL (TBR)
Message was sent while issue was closed.
Description was changed from ========== [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y TBR=jkummerow@chromium.org ========== to ========== [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y TBR=jkummerow@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y TBR=jkummerow@chromium.org ========== to ========== [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. BUG=chromium:571064 LOG=Y TBR=jkummerow@chromium.org Committed: https://crrev.com/bae0d6c8dccbff5bd1c21d3d81315b14649e3a9b Cr-Commit-Position: refs/heads/master@{#33058} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bae0d6c8dccbff5bd1c21d3d81315b14649e3a9b Cr-Commit-Position: refs/heads/master@{#33058}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
