src/crankshaft/hydrogen.cc - Issue 1548363003: [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1548363003: [crankshaft] Don't inline array resize operations if receiver's proto is not a JSObject. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index c17ce17a1d1698f56cc49c73f720943354876bb8..2bf85f87c2a04592828fbff1f3068582266ed442 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -8703,7 +8703,7 @@ bool HOptimizedGraphBuilder::IsReadOnlyLengthDescriptor(

// static

bool HOptimizedGraphBuilder::CanInlineArrayResizeOperation(

Handle<Map> receiver_map) {

- return !receiver_map.is_null() &&

+ return !receiver_map.is_null() && receiver_map->prototype()->IsJSObject() &&

receiver_map->instance_type() == JS_ARRAY_TYPE &&

IsFastElementsKind(receiver_map->elements_kind()) &&

!receiver_map->is_dictionary_map() && !receiver_map->is_observed() &&

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-571064.js » ('j') | no next file with comments »