Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: net/tools/flip_server/mem_cache.h

Issue 1548293002: Use scoped_ptr in Files-map and remove unused functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/tools/flip_server/mem_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/flip_server/mem_cache.h
diff --git a/net/tools/flip_server/mem_cache.h b/net/tools/flip_server/mem_cache.h
index d35322a1c57122e79647f095ae4b3b88ee78d535..6b85149eca0e804e6447f72f6a3a730e152c35f2 100644
--- a/net/tools/flip_server/mem_cache.h
+++ b/net/tools/flip_server/mem_cache.h
@@ -114,14 +114,12 @@ class MemCacheIter {
class MemoryCache {
public:
- typedef std::map<std::string, FileData*> Files;
+ using Files = std::map<std::string, scoped_ptr<FileData>>;
Ryan Hamilton 2015/12/28 15:06:30 Is there any reason to prefer using here to typede
Avi (use Gerrit) 2015/12/28 15:09:43 It's the new hotness as it's much easier to read a
Ryan Hamilton 2015/12/28 18:23:25 Definitely happy to follow the style guide, so +1
public:
MemoryCache();
virtual ~MemoryCache();
- void CloneFrom(const MemoryCache& mc);
-
void AddFiles();
// virtual for unittests
@@ -140,7 +138,6 @@ class MemoryCache {
private:
void InsertFile(FileData* file_data);
- void ClearFiles();
Files files_;
std::string cwd_;
« no previous file with comments | « no previous file | net/tools/flip_server/mem_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698