Use scoped_ptr in Files-map and remove unused functions

net/tools/flip_server/mem_cache.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TOOLS_FLIP_SERVER_MEM_CACHE_H_
 #define NET_TOOLS_FLIP_SERVER_MEM_CACHE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 96 matching lines @@
   int priority;
   bool transformed_header;
   size_t body_bytes_consumed;
   uint32_t stream_id;
   uint32_t max_segment_size;
   size_t bytes_sent;
 };
 
 class MemoryCache {
  public:
-  typedef std::map<std::string, FileData*> Files;
+  using Files = std::map<std::string, scoped_ptr<FileData>>;

[Ryan Hamilton, 2015/12/28 15:06:30]

Is there any reason to prefer using here to typedef?

[Avi (use Gerrit), 2015/12/28 15:09:43]

It's the new hotness as it's much easier to read and reason about.

http://chromium-cpp.appspot.com/ says about "using" : "Use instead of typedef,
unless the header needs to be compatible with C."

[Ryan Hamilton, 2015/12/28 18:23:25]

Definitely happy to follow the style guide, so +1 on this change. That being
said, just for my understanding is there any difference between:

  typedef old_type new_type;

and

  using new_type = old_type;

or are the synonymous? There is so much new hotness in C++11 that I'm not on top
of all of it :>

 
  public:
   MemoryCache();
   virtual ~MemoryCache();
 
-  void CloneFrom(const MemoryCache& mc);
-
   void AddFiles();
 
   // virtual for unittests
   virtual void ReadToString(const char* filename, std::string* output);
 
   void ReadAndStoreFileContents(const char* filename);
 
   FileData* GetFileData(const std::string& filename);
 
   bool AssignFileData(const std::string& filename, MemCacheIter* mci);
 
   // For unittests
   void InsertFile(const BalsaHeaders* headers,
                   const std::string& filename,
                   const std::string& body);
 
  private:
   void InsertFile(FileData* file_data);
-  void ClearFiles();
 
   Files files_;
   std::string cwd_;
 };
 
 class NotifierInterface {
  public:
   virtual ~NotifierInterface() {}
   virtual void Notify() = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_TOOLS_FLIP_SERVER_MEM_CACHE_H_