Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.

Committed: https://crrev.com/2d06d8be21b5d0730628e3189059d54754501405
Cr-Commit-Position: refs/heads/master@{#367056}

[Olli Raula, 2015-12-28 09:22:00]

Description was changed from

==========
Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.
==========

to

==========
Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.
==========

[Olli Raula, 2015-12-28 09:22:00]

olli.raula@intel.com changed reviewers:
+ rch@chromium.org

[Olli Raula, 2015-12-28 09:23:06]

Could you review?

[Ryan Hamilton, 2015-12-28 15:06:30]

LGTM

https://codereview.chromium.org/1548293002/diff/1/net/tools/flip_server/mem_c...
File net/tools/flip_server/mem_cache.h (right):

https://codereview.chromium.org/1548293002/diff/1/net/tools/flip_server/mem_c...
net/tools/flip_server/mem_cache.h:117: using Files = std::map<std::string,
scoped_ptr<FileData>>;
Is there any reason to prefer using here to typedef?

[Avi (use Gerrit), 2015-12-28 15:09:43]

https://codereview.chromium.org/1548293002/diff/1/net/tools/flip_server/mem_c...
File net/tools/flip_server/mem_cache.h (right):

https://codereview.chromium.org/1548293002/diff/1/net/tools/flip_server/mem_c...
net/tools/flip_server/mem_cache.h:117: using Files = std::map<std::string,
scoped_ptr<FileData>>;
On 2015/12/28 15:06:30, Ryan Hamilton wrote:
> Is there any reason to prefer using here to typedef?

It's the new hotness as it's much easier to read and reason about.

http://chromium-cpp.appspot.com/ says about "using" : "Use instead of typedef,
unless the header needs to be compatible with C."

[Ryan Hamilton, 2015-12-28 18:23:25]

https://codereview.chromium.org/1548293002/diff/1/net/tools/flip_server/mem_c...
File net/tools/flip_server/mem_cache.h (right):

https://codereview.chromium.org/1548293002/diff/1/net/tools/flip_server/mem_c...
net/tools/flip_server/mem_cache.h:117: using Files = std::map<std::string,
scoped_ptr<FileData>>;
On 2015/12/28 15:09:43, Avi wrote:
> On 2015/12/28 15:06:30, Ryan Hamilton wrote:
> > Is there any reason to prefer using here to typedef?
> 
> It's the new hotness as it's much easier to read and reason about.
> 
> http://chromium-cpp.appspot.com/ says about "using" : "Use instead of typedef,
> unless the header needs to be compatible with C."

Definitely happy to follow the style guide, so +1 on this change. That being
said, just for my understanding is there any difference between:

  typedef old_type new_type;

and

  using new_type = old_type;

or are the synonymous? There is so much new hotness in C++11 that I'm not on top
of all of it :>

[Ryan Hamilton, 2015-12-28 18:23:40]

Oh, and still LGTM, of course.

[Olli Raula, 2015-12-29 06:36:27]

> or are the synonymous? There is so much new hotness in C++11 that I'm not on
top
> of all of it :>

I think that C compatibility is only difference,
http://stackoverflow.com/questions/10747810/what-is-the-difference-between-ty...

[Olli Raula, 2015-12-29 06:37:10]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-12-29 06:37:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1548293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1548293002/1

[commit-bot: I haz the power, 2015-12-29 06:41:50]

Description was changed from

==========
Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.
==========

to

==========
Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.
==========

[commit-bot: I haz the power, 2015-12-29 06:41:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-29 06:42:36]

Description was changed from

==========
Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.
==========

to

==========
Use scoped_ptr in Files-map and remove unused functions

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.

Committed: https://crrev.com/2d06d8be21b5d0730628e3189059d54754501405
Cr-Commit-Position: refs/heads/master@{#367056}
==========

[commit-bot: I haz the power, 2015-12-29 06:42:37]

Patchset 1 (id:??) landed as
https://crrev.com/2d06d8be21b5d0730628e3189059d54754501405
Cr-Commit-Position: refs/heads/master@{#367056}