Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1848)

Unified Diff: chrome/browser/resources/media_router/media_router_ui_interface.js

Issue 1548283003: Add P2 UMA metrics for Media Router user actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/media_router_ui_interface.js
diff --git a/chrome/browser/resources/media_router/media_router_ui_interface.js b/chrome/browser/resources/media_router/media_router_ui_interface.js
index fc1312f39ca0cf6e79393fff5d142ba810ab2ce0..b2324f10bf62e05e9c69c8f0ffccf2992412a22e 100644
--- a/chrome/browser/resources/media_router/media_router_ui_interface.js
+++ b/chrome/browser/resources/media_router/media_router_ui_interface.js
@@ -137,7 +137,7 @@ cr.define('media_router.browserApi', function() {
* @param {!media_router.Route} route
*/
function closeRoute(route) {
- chrome.send('closeRoute', [{routeId: route.id}]);
+ chrome.send('closeRoute', [{routeId: route.id, isLocal: route.isLocal}]);
}
/**
@@ -148,6 +148,24 @@ cr.define('media_router.browserApi', function() {
}
/**
+ * Reports the index of the selected sink.
+ *
+ * @param {number} sinkIndex
+ */
+ function reportClickedSinkIndex(sinkIndex) {
+ chrome.send('reportClickedSinkIndex', [sinkIndex]);
+ }
+
+ /**
+ * Reports the cast mode that the user selected.
+ *
+ * @param {number} castModeType
+ */
+ function reportSelectedCastMode(castModeType) {
+ chrome.send('reportSelectedCastMode', [castModeType]);
+ }
+
+ /**
* Reports the current number of sinks.
*
* @param {number} sinkCount
@@ -181,6 +199,8 @@ cr.define('media_router.browserApi', function() {
closeDialog: closeDialog,
closeRoute: closeRoute,
onInitialDataReceived: onInitialDataReceived,
+ reportClickedSinkIndex: reportClickedSinkIndex,
+ reportSelectedCastMode: reportSelectedCastMode,
reportSinkCount: reportSinkCount,
requestInitialData: requestInitialData,
requestRoute: requestRoute,

Powered by Google App Engine
This is Rietveld 408576698