Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/resources/media_router/media_router.js

Issue 1548283003: Add P2 UMA metrics for Media Router user actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/media_router.js
diff --git a/chrome/browser/resources/media_router/media_router.js b/chrome/browser/resources/media_router/media_router.js
index 0c55b88d95a858285a38a663d047ee9dc9df8218..b019b3c3fbede06b8e1028585f46b5559b5d02a5 100644
--- a/chrome/browser/resources/media_router/media_router.js
+++ b/chrome/browser/resources/media_router/media_router.js
@@ -22,12 +22,14 @@ cr.define('media_router', function() {
container = $('media-router-container');
media_router.ui.setContainer(container);
+ container.addEventListener('cast-mode-selected', onCastModeSelected);
container.addEventListener('close-button-click', onCloseDialogEvent);
container.addEventListener('close-dialog', onCloseDialogEvent);
container.addEventListener('close-route-click', onCloseRouteClick);
container.addEventListener('create-route', onCreateRoute);
container.addEventListener('issue-action-click', onIssueActionClick);
container.addEventListener('report-sink-count', onSinkCountReported);
+ container.addEventListener('sink-click', onSinkClick);
}
/**
@@ -57,6 +59,18 @@ cr.define('media_router', function() {
}
/**
+ * Reports the selected cast mode.
+ * Called when the user selects a cast mode from the picker.
+ *
+ * @param {{detail: {castModeType: number}}} data
+ * Parameters in |data|.detail:
+ * castModeType - type of cast mode selected by the user.
+ */
+ function onCastModeSelected(data) {
+ media_router.browserApi.reportSelectedCastMode(data.detail.castModeType);
+ }
+
+ /**
* Creates a media route.
* Called when the user requests to create a media route.
*
@@ -83,6 +97,18 @@ cr.define('media_router', function() {
}
/**
+ * Reports the index of the sink that was clicked.
+ * Called when the user selects a sink on the sink list.
+ *
+ * @param {{detail: {index: number}}} data
+ * Paramters in |data|.detail:
+ * index - the index of the clicked sink.
+ */
+ function onSinkClick(data) {
+ media_router.browserApi.reportClickedSinkIndex(data.detail.index);
+ }
+
+ /**
* Reports the current sink count.
* Called 3 seconds after the dialog is initially opened.
*

Powered by Google App Engine
This is Rietveld 408576698