Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1548223002: remove cruft from SkTypes.h, including SkBool (Closed)

Created:
4 years, 12 months ago by reed1
Modified:
4 years, 12 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -183 lines) Patch
M include/core/SkTypes.h View 2 chunks +0 lines, -17 lines 0 comments Download
M include/utils/SkInterpolator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDisplayType.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkDisplayTypes.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/animator/SkOperandIterpolator.cpp View 1 3 chunks +1 line, -3 lines 0 comments Download
M src/animator/SkScript.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/animator/SkScript2.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +16 lines, -12 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/utils/SkInterpolator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/views/SkView.cpp View 17 chunks +105 lines, -140 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548223002/1
4 years, 12 months ago (2015-12-27 03:53:40 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4997)
4 years, 12 months ago (2015-12-27 03:54:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548223002/20001
4 years, 12 months ago (2015-12-27 04:03:00 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4993)
4 years, 12 months ago (2015-12-27 04:05:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548223002/40001
4 years, 12 months ago (2015-12-27 20:32:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548223002/40001
4 years, 12 months ago (2015-12-27 20:35:53 UTC) #15
commit-bot: I haz the power
4 years, 12 months ago (2015-12-27 20:47:29 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9a878a00ef2c2eb72628c807be5969e2d8098317

Powered by Google App Engine
This is Rietveld 408576698