Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: include/core/SkTypes.h

Issue 1548223002: remove cruft from SkTypes.h, including SkBool (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/utils/SkInterpolator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkTypes.h
diff --git a/include/core/SkTypes.h b/include/core/SkTypes.h
index 261fcaea4210893cbedb8a61076b4358b5e5400e..c112b0364f1ab59967e97d40790b59532a20d397 100644
--- a/include/core/SkTypes.h
+++ b/include/core/SkTypes.h
@@ -248,12 +248,6 @@ typedef int S16CPU;
typedef unsigned U16CPU;
/**
- * Meant to be faster than bool (doesn't promise to be 0 or 1,
- * just 0 or non-zero
- */
-typedef int SkBool;
-
-/**
* Meant to be a small version of bool, for storage purposes. Will be 0 or 1
*/
typedef uint8_t SkBool8;
@@ -441,17 +435,6 @@ template <typename T> static inline const T& SkTPin(const T& value, const T& min
return SkTMax(SkTMin(value, max), min);
}
-static inline uint32_t SkSetClearShift(uint32_t bits, bool cond,
- unsigned shift) {
- SkASSERT((int)cond == 0 || (int)cond == 1);
- return (bits & ~(1 << shift)) | ((int)cond << shift);
-}
-
-static inline uint32_t SkSetClearMask(uint32_t bits, bool cond,
- uint32_t mask) {
- return cond ? bits | mask : bits & ~mask;
-}
-
///////////////////////////////////////////////////////////////////////////////
/** Use to combine multiple bits in a bitmask in a type safe way.
« no previous file with comments | « no previous file | include/utils/SkInterpolator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698