components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad headers Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/credential_manager_password_form_manager.cc ('k') | components/password_manager/core/browser/fake_affiliation_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index d31a0eec8344f7d9484a879baa0977e04132c860..f96be5d3694a4a686b2012a646c5583ff1ca8476 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -4,6 +4,8 @@

#include "components/password_manager/core/browser/credential_manager_pending_request_task.h"

+#include <utility>

#include "components/autofill/core/common/password_form.h"

#include "components/password_manager/core/browser/affiliated_match_helper.h"

#include "components/password_manager/core/browser/password_manager_client.h"

@@ -102,14 +104,14 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

std::swap(*it, local_results[0]);

// Clear the form pointer since its owner is being passed.

zero_click_form_to_return = nullptr;

- delegate_->client()->NotifyUserAutoSignin(local_results.Pass());

+ delegate_->client()->NotifyUserAutoSignin(std::move(local_results));

delegate_->SendCredential(id_, info);

return;

}

if (zero_click_only_ ||

!delegate_->client()->PromptUserToChooseCredentials(

- local_results.Pass(), federated_results.Pass(), origin_,

+ std::move(local_results), std::move(federated_results), origin_,

base::Bind(

&CredentialManagerPendingRequestTaskDelegate::SendCredential,

base::Unretained(delegate_), id_))) {