components/password_manager/core/browser/credential_manager_password_form_manager.cc - Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_password_form_manager.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad headers Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliation_fetcher_unittest.cc ('k') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_password_form_manager.cc

diff --git a/components/password_manager/core/browser/credential_manager_password_form_manager.cc b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

index 61b79490b8cad4bd35a25a9565f8facf3a78519b..194f9c63dc4ec0e855c1c5e0dded00622bcb480a 100644

--- a/components/password_manager/core/browser/credential_manager_password_form_manager.cc

+++ b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

@@ -4,6 +4,8 @@

#include "components/password_manager/core/browser/credential_manager_password_form_manager.h"

+#include <utility>

#include "base/macros.h"

#include "components/autofill/core/common/password_form.h"

#include "components/password_manager/core/browser/password_manager_client.h"

@@ -32,7 +34,7 @@ CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {

void CredentialManagerPasswordFormManager::OnGetPasswordStoreResults(

ScopedVector<autofill::PasswordForm> results) {

- PasswordFormManager::OnGetPasswordStoreResults(results.Pass());

+ PasswordFormManager::OnGetPasswordStoreResults(std::move(results));

// Mark the form as "preferred", as we've been told by the API that this is

// indeed the credential set that the user used to sign into the site.