SampleApp: remove SkWindow::onPDFSaved, it does not work

SampleApp: remove SkWindow::onPDFSaved, it does not work

Remove SkWindow::onPDFSaved, it does not work and it is not used anymore.

Also, it is very SampleApp -specific feature implemented in SkWindow class. 
SkWindow class is probably intended to be more app-agnosting than 
what this method implies.

Presumably the idea of the callback was to inform the user of
SampleApp that the PDF was saved to a certain location.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1547923002

Committed: https://skia.googlesource.com/skia/+/3ca73360493ba71831c86c8c5f9c36187c0355ca

[Kimmo Kinnunen, 2015-12-23 09:54:21]

Description was changed from

==========
SampleApp: remove SkWindow::onPDFSaved, it does not work

Remove SkWindow::onPDFSaved, it does not work. Presumably
the idea of the callbac was to inform the user of SampleApp that
the PDF was saved to a certain location.

It is SampleApp -specific feature and it does not work in any SampleApp
anymore.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
==========

to

==========
SampleApp: remove SkWindow::onPDFSaved, it does not work

Remove SkWindow::onPDFSaved, it does not work. Presumably
the idea of the callbac was to inform the user of SampleApp that
the PDF was saved to a certain location.

It is SampleApp -specific feature and it does not work in any SampleApp
anymore.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-01-07 12:09:59]

Description was changed from

==========
SampleApp: remove SkWindow::onPDFSaved, it does not work

Remove SkWindow::onPDFSaved, it does not work. Presumably
the idea of the callbac was to inform the user of SampleApp that
the PDF was saved to a certain location.

It is SampleApp -specific feature and it does not work in any SampleApp
anymore.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SampleApp: remove SkWindow::onPDFSaved, it does not work

Remove SkWindow::onPDFSaved, it does not work and it is not used anymore.

Also, it is very SampleApp -specific feature implemented in SkWindow class. 
SkWindow class is probably intended to be more app-agnosting than 
what this method implies.

Presumably the idea of the callback was to inform the user of
SampleApp that the PDF was saved to a certain location.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-01-07 12:10:13]

kkinnunen@nvidia.com changed reviewers:
+ reed@google.com, scroggo@google.com

[reed1, 2016-01-07 14:42:59]

reed@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-01-14 15:30:25]

lgtm

[Kimmo Kinnunen, 2016-01-15 09:41:11]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2016-01-15 09:41:12]

The patchset sent to the CQ was uploaded after l-g-t-m from halcanary@google.com
Link to the patchset: https://codereview.chromium.org/1547923002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-01-15 09:41:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547923002/40001

[commit-bot: I haz the power, 2016-01-15 09:42:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 09:42:28]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[Kimmo Kinnunen, 2016-01-15 10:00:49]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@chromium.org, bsalomon@google.com, djsollen@chromium.org,
djsollen@google.com, reed@chromium.org

[Kimmo Kinnunen, 2016-01-15 10:00:50]

PTAL, public API change.

[djsollen, 2016-01-15 13:37:34]

seems to me that SampleApp.cpp:1311 is missing a call to this->onPDFSaved()
which would then trigger all this code to be used.

[mtklein, 2016-01-15 13:47:51]

On 2016/01/15 13:37:34, djsollen wrote:
> seems to me that SampleApp.cpp:1311 is missing a call to this->onPDFSaved()
> which would then trigger all this code to be used.

seems to me that means we never cared about any of this code

[bsalomon, 2016-01-15 14:36:25]

On 2016/01/15 13:47:51, mtklein wrote:
> On 2016/01/15 13:37:34, djsollen wrote:
> > seems to me that SampleApp.cpp:1311 is missing a call to this->onPDFSaved()
> > which would then trigger all this code to be used.
> 
> seems to me that means we never cared about any of this code

If Hal doesn't care then I imagine nobody cares. lgtm

[Kimmo Kinnunen, 2016-01-18 08:36:46]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-01-18 08:36:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547923002/40001

[commit-bot: I haz the power, 2016-01-18 08:47:17]

Description was changed from

==========
SampleApp: remove SkWindow::onPDFSaved, it does not work

Remove SkWindow::onPDFSaved, it does not work and it is not used anymore.

Also, it is very SampleApp -specific feature implemented in SkWindow class. 
SkWindow class is probably intended to be more app-agnosting than 
what this method implies.

Presumably the idea of the callback was to inform the user of
SampleApp that the PDF was saved to a certain location.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SampleApp: remove SkWindow::onPDFSaved, it does not work

Remove SkWindow::onPDFSaved, it does not work and it is not used anymore.

Also, it is very SampleApp -specific feature implemented in SkWindow class. 
SkWindow class is probably intended to be more app-agnosting than 
what this method implies.

Presumably the idea of the callback was to inform the user of
SampleApp that the PDF was saved to a certain location.

For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.

BUG=skia:4733
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3ca73360493ba71831c86c8c5f9c36187c0355ca
==========

[commit-bot: I haz the power, 2016-01-18 08:47:17]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3ca73360493ba71831c86c8c5f9c36187c0355ca